Update code comments for IE 10/11. #299 #299
Conversation
|
Thanks to #291 and @mkempe, I noticed that the HTML5 block element test is insufficient to show that 1 or 2 elements are display inline when they are interspersed among a bunch of block elements. So I've updated Test 3.1 and the code comment. Here's the screenshots. 3.1 HTML5 elements should render as blockIn Firefox,
I've |
|
Man, this issue is way too big. Please can you break each thing into a separate issue. |
|
Ok! |
|
FYI, I can't reproduce any of the IE 11 issues (in IE 11.0.9600.16428, Windows 7). |
|
or the Firefox ones (26 and 27 on OS X 10.8) |
|
Are you using the standard test.html? Or are you using the one where I removed normalize.css so that I could see the uncorrected browser bugs? (That's why there's a red border around the page in the screenshots.) This entire issue is about updating the code comments of bugs that normalize.css already fixes. |
|
oh right. reading fail. |
|
Should all be addressed in #305. Let me know if anything is missing. The HTML5 block-level tests seem fine. Anything that isn't |
|
Sorry. I was speaking at a conference in New Zealand and didn't get home until today. |
In my Sass/Compass version of Normalize, I can turn on or off normalize rules based on the developers choice of "minimum supported browser versions". So if you don't want IE 8 and lower, you only get the relavent rules from normalize. So I track the code comments of normalize.css carefully.
In normalize.css 3.0.0 I noticed a couple code comments got IE 10 added to them, but it looks like a comprehensive review of all the "IE" comments is needed now that IE 11 is out.
I made a copy of normalize.css' test.html page and removed the normalize.css stylesheet, so that I could see the un-corrected bugs and then tested IE 10 and IE 11 using browserstack. Note: it takes quite a while to do the testing and screenshots, so I only tested rules that previously mentioned IE. I'd need to automate the screenshots if I wanted to test all the rules.
For any code comment mentioning "IE 8/9" or "IE 8/9/10" or "IE 8+" about a bug that was still broken in IE 11, I changed to just be "IE"; that seemed in line with other code comments. All other comment changes were straight-forward, except for test 3.1.
3.1 HTML5 elements should render as block
It looks like the HTML5 element "block" display has been fixed for almost all elements. But I noticed that IE 10/11, as well as Firefox 27, still use an inline display of the
summaryelement. I made a note of that.4.1 audio, canvas, progress, video should render as inline-block and baseline-aligned
This has been fixed in IE 10/11.
5.1 template, [hidden] should not display
Now this is an interesting one. In IE 10,
templateis hidden, but[hidden]is not. And in IE 11, we have the reverse. So there's a regression in IE 11 fortemplate.6.1 links should have a transparent background when active
Fixed in IE 11.
7.1 abbr[title] should have a dotted bottom border
Still broken in IE 10/11.
11.1 mark should have a yellow background
Fixed in IE 10/11.
14.1 img should not have a border when wrapped in an anchor
Still broken in IE 10, but fixed in IE 11.
15.1 svg should not overflow
Still broken in IE 10/11. I removed the word "oddly" from the comment, since its superfluous. All browser bugs are "odd". :-)
16.1 figure should have margins
Fixed in IE 10/11.
21.1 button should have visible overflow
Still broken in IE 10/11.
22.1 button, select should not inherit text-transform
Still broken in IE 10/11.
27.1 input[type="checkbox"], input[type="radio"] should have a border-box box model
Broken in IE 10, but fixed in IE 11.
27.2 input[type="checkbox"], input[type="radio"] should not have padding
Broken in IE 10, but fixed in IE 11.
31.1 legend should inherit color
Still broken in IE 10/11.
32.1 textarea should not have a scrollbar unless overflowing
Still broken in IE 10/11.