Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Menu is not included in the "correct block display" rule. #370

Closed
thierryk opened this issue Sep 14, 2014 · 3 comments
Closed

Menu is not included in the "correct block display" rule. #370

thierryk opened this issue Sep 14, 2014 · 3 comments

Comments

@thierryk
Copy link

Shouldn't menu be added to the rule below?

article,
aside,
details,
figcaption,
figure,
footer,
header,
hgroup,
main,
nav,
section,
summary {
  display: block;
}
@salexzee
Copy link

I disagree. menu is currently experimental and only supported by Firefox. It probably shouldn't be added until it is at least partially supported by all the major browsers.

@thierryk
Copy link
Author

I did a quick check on my Mac and found menu in these UA style sheets:

Chrome 37 and Safari 7:

ul, menu, dir {
    display: block;
    list-style-type: disc;
    -webkit-margin-before: 1em;
    -webkit-margin-after: 1em;
    -webkit-margin-start: 0px;
    -webkit-margin-end: 0px;
    -webkit-padding-start: 40px;
}

Firefox 32:

ul, menu, dir {
    -moz-padding-start: 40px;
    display: block;
    list-style-type: disc;
    margin: 1em 0;
}

In my opinion, this should justify the addition of menu in the rule that styles html5 elements as block-level elements.

@necolas
Copy link
Owner

necolas commented Oct 4, 2014

Sounds good to me

@necolas necolas closed this as completed in 5962c89 Oct 4, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@thierryk @necolas @salexzee