Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow nested fragments on Head #44773

Open
wants to merge 1 commit into
base: canary
Choose a base branch
from
Open

Conversation

aitorllj93
Copy link

@aitorllj93 aitorllj93 commented Jan 11, 2023

Not sure about this change does what I expect as haven't tested it, but I think it would be great to support nested fragments on Head component. Also, it's very problematic that due to the current implementation, when there's a nested fragment it fails silently, and if you mocking the Head component in your unit tests it will work as expected but not in the real world

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have a helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • e2e tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have a helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running pnpm build && pnpm lint
  • The "examples guidelines" are followed from our contributing doc

Not sure about this change does what I expect as haven't tested it, but I think it would be great to support nested fragments on Head component
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants