Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix:Manage Firefox and Safari Network error message #44929

Open
wants to merge 1 commit into
base: canary
Choose a base branch
from

Conversation

dtrucs
Copy link

@dtrucs dtrucs commented Jan 16, 2023

Not all browsers implement the network error message in the same way:
For example if I execute fetch('//foo.bar/').catch(err => console.log(err.message)) in Chrome / Firefox / Safari browsers console, I get respectively:

  • Failed to fetch
  • NetworkError when attempting to fetch resource.
  • Load failed

This PR fixes it.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have a helpful link attached, see contributing.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant