Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all opinionated rules #649

Merged
merged 1 commit into from Mar 26, 2017
Merged

Remove all opinionated rules #649

merged 1 commit into from Mar 26, 2017

Conversation

jonathantneal
Copy link
Contributor

  • Remove changing the default font family in all browsers.
  • Remove the removal of margin on body in all browsers.
  • Remove the removal of outline on focused links when they are also
    active or hovered in all browsers (opinionated).
  • Remove changing the font styles of input controls in all browsers.
  • Remove the changing of border, margin, and padding of fieldsets in
    all browsers.

- Remove changing the default font family in all browsers.
- Remove the removal of margin on body in all browsers.
- Remove the removal of outline on focused links when they are also
active or hovered in all browsers (opinionated).
- Remove changing the font styles of input controls in all browsers.
- Remove the changing of border, margin, and padding of fieldsets in
all browsers.
@zemirco
Copy link

zemirco commented Mar 15, 2017

Happy new year 😄

What's the status of this issue?

@jonathantneal jonathantneal merged commit b5f0e9d into master Mar 26, 2017
@jonathantneal jonathantneal deleted the feature/unopinionated branch Mar 26, 2017
@englishextra
Copy link

englishextra commented Mar 26, 2017

Remove changing the default font family in all browsers.
Remove the removal of margin on body in all browsers.
Remove the removal of outline on focused links when they are also
active or hovered in all browsers (opinionated).
Remove changing the font styles of input controls in all browsers.
Remove the changing of border, margin, and padding of fieldsets in
all browsers.

I already add first thing after font-face paths and normalize, a normalizer of normalize, i.e I remove webkit outline on focused links and select/buttons (now they're gone, so my rules will defend Chrome's blue outline). By the way,
thanks for Remove changing the font styles of input controls, and Remove the changing of border, margin, and padding of fieldsets

also:

Remove changing the default font family in all browsers.
Remove the removal of margin on body in all browsers.
Remove the removal of outline on focused links when they are also
active or hovered in all browsers (opinionated).

They're so debatable, therefore in my view it's all right for them to be left alone.

@jonathantneal
Copy link
Contributor Author

@zemirco, it is merged, tagged, and published.

normalize.css no longer includes opinionated rules, and focuses exclusively on browser normalization.

@KingScooty
Copy link

KingScooty commented Apr 4, 2017

Thanks for removing this stuff. I'm confused/slightly annoyed how opinionated rules made their way into this project in the first place! (we were using 5.0.0 in a project, and these rules actually caused a lot of headaches—particularly the line-height for form elements!!)

@ur5us
Copy link

ur5us commented Apr 23, 2017

@jonathantneal Can you elaborate a little what constitutes an opinionated rule? For instance, I'd assume that the font settings for input elements are not the same across different browsers so it'd make sense to normalize things like font-size et al.

@englishextra
Copy link

@jonathantneal In my case select's font-family set to sans-serif broke lots of styles. Form elements styling is an ungracious task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants