Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update normalize.css #661

Merged
merged 2 commits into from Mar 26, 2017
Merged

Update normalize.css #661

merged 2 commits into from Mar 26, 2017

Conversation

mattbrundage
Copy link
Contributor

@jonathantneal jonathantneal merged commit a562961 into necolas:master Mar 26, 2017
@jonathantneal
Copy link
Contributor

This was super helpful and really polished the v6 release. Thanks, @mattbrundage !

@nekolab
Copy link

nekolab commented May 24, 2017

Hi, I'm not sure about change in this commit, since it seems no bottom border in chrome 57- in my mind.

@mattbrundage mattbrundage deleted the patch-2 branch May 24, 2017
@mattbrundage
Copy link
Contributor Author

@nekolab, if this commit is any indication, then you're right -- there was no prior border-bottom rule in older versions of Chrome.

Support for the new text-decoration properties landed in Chrome 57, while default abbr styling landed in Chrome 58. Perhaps we should just omit mention of Chrome from these two abbr comments, given the closeness of these two feature landings..

@nekolab
Copy link

nekolab commented May 24, 2017

@mattbrundage Yeah, what about revert change in this commit and change comment 2 to
2. Add the correct text decoration in Chrome 58-, Edge, IE, Opera, and Safari.?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants