Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Markdown syntax #663

Merged
merged 3 commits into from May 1, 2017
Merged

Fix Markdown syntax #663

merged 3 commits into from May 1, 2017

Conversation

yochem
Copy link
Contributor

@yochem yochem commented Mar 28, 2017

I think the list misses one.

Changed

## Browser support

* Chrome (last two)
* Edge (last two)
* Firefox (last two)
* Firefox ESR
* Internet Explorer 8+
* iOS Safari (last two)
* Opera (last two)
* Safari 6+

*[Normalize.css v1 provides legacy browser support]
(https://github.com/necolas/normalize.css/tree/v1) (IE 6+, Safari 4+),
but is no longer actively developed.*

into

## Browser support

* Chrome (last two)
* Edge (last two)
* Firefox (last two)
* Firefox ESR
* Internet Explorer 8+
* iOS Safari (last two)
* Opera (last two)
* Safari 6+
* [*Normalize.css v1 provides legacy browser support*](https://github.com/necolas/normalize.css/tree/v1) *(IE 6+, Safari 4+), but is no longer actively developed.*

(weird, the preview doesn't show the italic properly? It looks normal on the markdown preview in Atom.)

screenshot markdown

@jonathantneal
Copy link
Contributor

Thanks for finding this bug, @yochem. The fix would be to change:

*[Normalize.css v1 provides legacy browser support]
(https://github.com/necolas/normalize.css/tree/v1)

to

*[Normalize.css v1 provides legacy browser support](https://github.com/necolas/normalize.css/tree/v1)

If you make that change, I’d happily accept this PR. Thanks again for spotting this and submitting a fix.

@yochem
Copy link
Contributor Author

yochem commented Apr 11, 2017

Done! It should be fine to merge it. 😄

@kevinvanrijn
Copy link

  • When this note was added in 0050384 it was not included in the browser support list.
    Currently, this pull includes it in that list.

  • When the markdown broke in 7f2eaef ( 4.0.0 #539 ) the intention was to italicize the note as far as I can tell.
    Currently, this pull does not retain that italicization.

Is this intentional?

@calvinjuarez
Copy link

Yeah, as @KIPdeKIP mentions, I think the correction should be:

*[Normalize.css v1 provides legacy browser support](https://github.com/necolas/normalize.css/tree/v1) (IE 6+, Safari 4+), but is no longer actively developed.*

or even

_[Normalize.css v1 provides legacy browser support](https://github.com/necolas/normalize.css/tree/v1) (IE 6+, Safari 4+), but is no longer actively developed._

so the output looks like

Normalize.css v1 provides legacy browser support (IE 6+, Safari 4+), but is no longer actively developed.

@kevinvanrijn
Copy link

kevinvanrijn commented Apr 30, 2017

Thank you for adding the italicization.

Note that it's still included in the browser support list. It's currently:

* Safari 6+
* _[Normalize.css v1 provides legacy browser support](https://github.com/necolas/normalize.css/tree/v1) (IE 6+, Safari 4+), but is no longer actively developed._

But both the original and the current state on master didn't include it. I personally prefer:

* Safari 6+

_[Normalize.css v1 provides legacy browser support](https://github.com/necolas/normalize.css/tree/v1) (IE 6+, Safari 4+), but is no longer actively developed._

  • Safari 6+

Normalize.css v1 provides legacy browser support (IE 6+, Safari 4+), but is no longer actively developed.



I'd like the opinion of one of the normalize.css people on how it's supposed to be formatted though.

@jonathantneal jonathantneal merged commit 44f1325 into necolas:master May 1, 2017
@jonathantneal
Copy link
Contributor

Thanks @yochem!

tagliala added a commit to tagliala/normalize.css that referenced this pull request Mar 3, 2019
* 'master' of https://github.com/necolas/normalize.css: (35 commits)
  8.0.1
  Render the main element correctly in IE
  Remove stylelint
  Fix typo in CHANGELOG
  v8.0.0
  Update CHANGELOG
  Don't remove search input cancel button in Chrome/Safari
  Add package-lock.json
  Remove bower
  Update browser support
  Point to yarnpkg's list of CDNs
  Remove the font-size test on html tag
  Inherit font family for inputs
  Restore gaps in links underline in iOS 8+ and Safari 8+
  7.0.0
  Revert changes to 'body' and form elements
  Non-functional maintenance
  Fix Markdown syntax (necolas#663)
  Correct the padding in firefox (necolas#671)
  Update CHANGELOG.md (necolas#670)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants