Remove Obsoleted Android 4.0 Code #712
Closed
+3
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove workaround for Android Open Source Browser in Android 4.0 fixing media buttons, which is obsoleted by Google and out of Normalize's Browser Support Guidelines.
|
Good catch! I’ll include this change in my derivative library. |
|
I’d love to see this normalization pulled. If it’s outside Normalize.css support, we should merge this and celebrate! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
A super simple, one line change to the specificity of a button rule, removing an old, no longer needed workaround.
This issue is in regards to the current line 278:
html [type="button"], /* 1 */with the note:
1. Prevent a WebKit bug where (2) destroys native audio and video controls in Android 4.This pull request returns the line to its original form of just:
[type="button"]as it was intended to be. The issue itself has been obsoleted by Google: https://issuetracker.google.com/issues/36950539 More recent Android updates have resolved the bug.This bug affected Android 4.0 from 2011. This browser version is outside of Normalize's documented Browser Support. Besides being beyond 2 versions of the browser version in the past, it is 6 whole OS versions behind the current version of Android. (And will be 7 next month). This version of the OS is no longer supported by even Google.