Don't make inputs have overflow:visible
#780
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses necolas#779 -- as noted there, `overflow:visible` has no effect on most input types in most browsers; and it only serves to drive browsers away from a consensus rendering, rather than bringing them closer to a consensus.
marella
added a commit
to marella/modernize
that referenced
this pull request
Jun 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This addresses #779 -- as noted there,
overflow:visiblehas no effect on most input types in most browsers (and has zero effect in Chrome/Safari). To the extent that it has effects, it only serves to drive browsers away from a consensus rendering, rather than bringing them closer to a consensus.