Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify legend element normalization #793

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Simplify legend element normalization #793

wants to merge 1 commit into from

Conversation

drify
Copy link

@drify drify commented Oct 16, 2019

See #100 (comment) and #536 . These two declarations are intended to fix IE8, which normalize.css dropped support long ago.

@drify
Simplify legend element normalization
9a75fd7 
See necolas#100 (comment) and necolas#536 . These two declarations are intended to fix IE8, which normalize.css dropped support long ago.
@Toddses
Copy link

Toddses commented Oct 18, 2019 •
edited

Both noted issues say this fix covers IE8 - 11. Normalize is still supporting IE10+.

@drify
Copy link
Author

drify commented Oct 18, 2019

Both noted issues say this fix covers IE8 - 11. Normalize is still supporting IE10+.

Hello,

Thanks much for your reply! But please check that again.

IE9-11 and Edge 12-13 can be completely fixed using box-sizing: border-box; max-width: 100%, but IE8 will still experience some issues as “the min-width property applies to content-box even if box-sizing is set to border-box” cite.

So remove the other two lines should be fine.

@drify
Copy link
Author

drify commented Nov 9, 2019

@Toddses @necolas Any ideas?

@nickmad1000
Copy link

GitHawk">

@@ -240,10 +240,8 @@ fieldset {
 legend {
   box-sizing: border-box; /* 1 */
   color: inherit; /* 2 */
-  display: table; /* 1 */
   max-width: 100%; /* 1 */
   padding: 0; /* 3 */
-  white-space: normal; /* 1 */
 }
 
 /**

```

```

<sub>Sent with <a href="http://githawk.com">GitHawk</a></sub>

marella added a commit to marella/modernize that referenced this pull request Jun 14, 2021
@marella
css: drop support for Edge 18-
4748301 
See necolas/normalize.css#793 necolas/normalize.css#830 necolas/normalize.css#780
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@drify @Toddses @nickmad1000