HR: no need for Firefox normalization #817
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Firefox no longer needs ``box-sizing`` and ``height`` rules, as the browser's stylesheet now specifies the correct ``box-sizing`` value and does not affect height. Tested in Firefox ESR (v. 68) through Firefox Developer Edition (v. 76). Paste this into Firefox's address bar to view the browser's default styles: ``view-source:resource://gre-resources/html.css``
|
Completely agree with @mattbrundage! I can confirm that the According to User Agent Stylesheet there is already defined /* <hr> noshade and color attributes are handled completely by
* the nsHTMLHRElement attribute mapping code
*/
hr {
display: block;
border: 1px inset;
margin-block-start: 0.5em;
margin-block-end: 0.5em;
margin-inline-start: auto;
margin-inline-end: auto;
color: gray;
-moz-float-edge: margin-box;
box-sizing: content-box;
}
hr[size="1"] {
border-style: solid none none none;
}
Also, I can confirm that
|
|
@necolas up |
marella
added a commit
to marella/modernize
that referenced
this pull request
Jun 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Firefox no longer needs
box-sizingandheightrules, as the browser's stylesheet now specifies the correctbox-sizingvalue and does not affect height. Tested in Firefox ESR (v. 68) through Firefox Developer Edition (v. 76).Paste this into Firefox's address bar to view the browser's default styles:
view-source:resource://gre-resources/html.css