Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the gap #843

Open
Ksengine opened this issue Oct 28, 2020 · 11 comments
Open

Remove the gap #843

Ksengine opened this issue Oct 28, 2020 · 11 comments

Comments

@Ksengine
Copy link

Remove the gap between audio, canvas, iframes,images, videos and the bottom of their containers

  • audio,
  • canvas,
  • iframe,
  • img,
  • svg,
  • video

i suggest:

audio,
canvas,
iframe,
img,
svg,
video {
  vertical-align: middle;
}

you added this as:

/**
 * 1. Correct `inline-block` display not defined in IE 8/9.
 * 2. Normalize vertical alignment of `progress` in Chrome, Firefox, and Opera.
 */

audio,
canvas,
progress,
video {
  display: inline-block; /* 1 */
  vertical-align: baseline; /* 2 */
}

can you explain me

@Stefan-Orn
Copy link

Stefan-Orn commented Oct 28, 2020 via email

@garrettw
Copy link

Remove the gap between audio, canvas, iframes,images, videos and the bottom of their containers

Is this something that most browsers are already doing, and only a few are not?

(This project is only for normalizing the differences between browsers, not making opinionated changes that affect all browsers.)

@Ksengine
Copy link
Author

normalize should support many browsers

@Ksengine
Copy link
Author

Ksengine commented Oct 29, 2020

we should use vertical-align: baseline to all
audio,
canvas,
iframe,
img,
svg,
video

@miquelfire
Copy link

What browsers are using baseline?

@Ksengine
Copy link
Author

its the default

The vertical-align property sets the vertical alignment of an element.

Default value: baseline

w3schools

@garrettw
Copy link

Rule # 1 of web design: NEVER rely on, or quote, W3Schools as a reliable resource.

normalize should support many browsers

It does that. I never suggested otherwise.

we should use vertical-align: baseline to all
audio,
canvas,
iframe,
img,
svg,
video

What?? In your first post you suggested middle for them all! If you're going to make a suggestion, at least make up your mind and be consistent.

@Ksengine
Copy link
Author

Rule # 1 of web design: NEVER rely on, or quote, W3Schools as a reliable resource.

why?

@Ksengine
Copy link
Author

i learned vertical-align: middle from html5 boilerplate
vertical-align: baseline is from W3Schools

@garrettw
Copy link

@Ksengine
Copy link
Author

thank you very much

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants