Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hr normalize applying wrong overflow value #860

Open
brady-shinners-bby opened this issue Jun 28, 2021 · 2 comments
Open

hr normalize applying wrong overflow value #860

brady-shinners-bby opened this issue Jun 28, 2021 · 2 comments

Comments

@brady-shinners-bby
Copy link

HTML5 spec for hr is to apply overflow: hidden, but normalize is currently applying overflow: visible. Please either remove what appears to be an unneeded override of a now-uniform default style or apply the expected overflow: hidden.
@garrettw
Copy link

Are you confirming that most browsers are respecting the spec now, or that the override definitely isn't needed anymore?

@brady-shinners-bby
Copy link
Author

The override does the opposite of the spec. I'm not familiar with what normalize's target browsers are, so not sure on whether overflow: visible should be replaced with overflow: hidden or just removed. For my use-case, all browsers we support adhere to overflow: hidden.

@nosilleg nosilleg mentioned this issue Sep 1, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@garrettw @brady-shinners-bby