Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed overflow: visible to overflow: hidden for hr element #861

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

costingh
Copy link

Applied the expected overflow value for hr element, accordingly to HTML5 spec

@@ -53,7 +53,7 @@ h1 {
hr {
box-sizing: content-box; /* 1 */
height: 0; /* 1 */
overflow: visible; /* 2 */
overflow: hidden; /* 2 */

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this change the comment on line number 50 is now incorrect.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are right, I need to look into more detail

Copy link
Author

@costingh costingh Jul 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the comment. Hope it is ok now :)

Copy link

@nosilleg nosilleg Jul 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the comment it would appear that Edge and IE were following spec and all other browsers weren't. So your change to the comment is still not accurate.

I'm not a maintainer so I don't know what the full expectations are for this, but for me personally I would expect the comment to reference the browsers that show overflow. This requires testing. If there are no browsers that are still showing overflow then the code change should be to remove the lines, not to change the value to "hidden". If there are still browsers showing overflow then it would be good to have that list so that eventually the code can be removed from this repo when they all follow spec.

@nuxodin
Copy link

nuxodin commented Jul 15, 2021

Do you have a link to the spec?
I can't find anything regarding css overflow.

@costingh
Copy link
Author

Do you have a link to the spec?
I can't find anything regarding css overflow.

This is the link to the spec: https://html.spec.whatwg.org/multipage/rendering.html#the-hr-element-2

@nosilleg
Copy link

nosilleg commented Sep 1, 2021

fixes #860

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants